chore: Update generate-method-action-types script to be used in a single package#7983
Merged
GuillaumeRx merged 6 commits intomainfrom Feb 19, 2026
Merged
Conversation
GuillaumeRx
force-pushed
the
gr/single-package-generate-action-types
branch
from
d1723db to
3de1c1e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
cryptodev-2s
left a comment
cryptodev-2s
left a comment
There was a problem hiding this comment.
The changes looks good to me! just one more suggestion can we add this to all packages and add a constraints too here https://github.com/MetaMask/core/blob/main/yarn.config.cjs#L41 ?
Contributor
Author
That sounds like something we could do once we migrated all the packages ? It's my main task right now to make all the controllers use |
cryptodev-2s
previously approved these changes
Feb 18, 2026
GuillaumeRx
force-pushed
the
gr/single-package-generate-action-types
branch
from
cf5798c to
d1af65e
Compare
cryptodev-2s
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This updates the
generate-method-action-typesto be used in a single package context rather than at the root of the monorepo.It also adds a positional arg that represents the path of the controller folder. It allows to define a path when the controller is not in the expected
src/folder.(It's expected that it doesn't find any definition for
profile-sync-controller)References
Checklist
Note
Low Risk
Build/lint tooling changes only, primarily affecting how codegen is invoked and where it searches for controllers; low chance of runtime impact but could break CI if a package lacks the new script/dependency.
Overview
Updates
yarn generate-method-action-typesto run per workspace (viaworkspaces foreach) instead of directly executing the root script.Adds a
generate-method-action-typesscript (andtsxdevDependency) to multiple packages, and updatesscripts/generate-method-action-types.tsto accept an optional positional[path]and scan that directory (defaultsrc) rather than iteratingpackages/*/srcfrom the monorepo root.Written by Cursor Bugbot for commit d1af65e. This will update automatically on new commits. Configure here.